jazzband / tablib

Python Module for Tabular Datasets in XLS, CSV, JSON, YAML, &c.
https://tablib.readthedocs.io/
MIT License
4.59k stars 590 forks source link

Dependencies removed from this project #446

Closed LuRsT closed 4 years ago

LuRsT commented 4 years ago

Hi, I realised that with the new version, the dependencies were removed (I think here: https://github.com/jazzband/tablib/issues/421) that caused a problem in one of our services, easily fixed by fixing the version to 0.14.0, but I was wondering if the point of this project is to be completely generic and not relying on anything unless the user needs to, or if you will have some requirements.

I'm talking specifically about the odfpy requirement, but it'd be good to know if you plan on being dependency-less, so I can amend our service the right way.

PS: We're using tablib through django-import-export

UPDATE: Here's others talking about the same problem: https://github.com/django-import-export/django-import-export/issues/1064

claudep commented 4 years ago

Yes, the idea was to not require any dependency unless you really want that format. If you want to continue having all possible formats, just depend on tablib[all]. Each "client" can decide which dependency they would like to have by default and which one they want to keep optional.

LuRsT commented 4 years ago

Alright, thanks @claudep!

hugovk commented 4 years ago

I'm talking specifically about the odfpy requirement, but it'd be good to know if you plan on being dependency-less, so I can amend our service the right way.

And in your case you could depend on tablib[ods].

Here it is in the docs:

LuRsT commented 4 years ago

Hi @hugovk, yeah, indeed that would work for me, since this is a dependency of a dependency for us, I'll fix to the previous version and update https://github.com/django-import-export/django-import-export/ to depend on the right version (and dependencies) of tablib.

Thanks for your help!