jazzband / tablib

Python Module for Tabular Datasets in XLS, CSV, JSON, YAML, &c.
https://tablib.readthedocs.io/
MIT License
4.59k stars 590 forks source link

Expose 'read_only' parameter for 'import_set' and 'import_book' #483

Closed dmosberger closed 3 years ago

dmosberger commented 3 years ago

Here is a proposed fix for issue #482.

Fixes #482.

codecov[bot] commented 3 years ago

Codecov Report

Merging #483 (bd18484) into master (e877404) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #483      +/-   ##
==========================================
+ Coverage   90.64%   90.66%   +0.01%     
==========================================
  Files          28       28              
  Lines        2608     2613       +5     
==========================================
+ Hits         2364     2369       +5     
  Misses        244      244              
Impacted Files Coverage Δ
src/tablib/formats/_xlsx.py 96.80% <100.00%> (ø)
tests/test_tablib.py 98.56% <100.00%> (+<0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e877404...bd18484. Read the comment docs.

claudep commented 3 years ago

Thanks, it looks good to me! Regarding docs, I would add an entry in HISTORY.md and document the parameter in formats.rst?

hugovk commented 3 years ago

Thank you!