jazzband / tablib

Python Module for Tabular Datasets in XLS, CSV, JSON, YAML, &c.

https://tablib.readthedocs.io/

MIT License

4.59k stars 590 forks source link

Fix "Invalid character / found in sheet title" during export to XLSX #490

Closed mpasternak closed 3 years ago

mpasternak commented 3 years ago

Fixes #489.

Make sure there are no bad characters in sheet names!

codecov[bot] commented 3 years ago

Codecov Report

Merging #490 (635811d) into master (7035d79) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #490      +/-   ##
==========================================
+ Coverage   90.67%   90.69%   +0.02%     
==========================================
  Files          28       28              
  Lines        2616     2623       +7     
==========================================
+ Hits         2372     2379       +7     
  Misses        244      244

Impacted Files	Coverage Δ
src/tablib/formats/_xlsx.py	`96.93% <100.00%> (+0.13%)`	:arrow_up:
tests/test_tablib.py	`98.56% <100.00%> (+<0.01%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7035d79...635811d. Read the comment docs.

mpasternak commented 3 years ago

Could you please include a small description in the commit first line, after the issue number?

I am not sure if I understand, what you mean.

Do you want me to change the commit message? Is this even possible? If it is, I have no idea how can I do that.

I could re-write everything (as this is a very small update) and re-commit with a better message, but is that what you want from me?

Please explain. I am willing to work with you on this patch but I am not sure if I understood correctly.

claudep commented 3 years ago

Exactly, I'd like a small description of the change in the commit message.

You can do that by: git commit --amend (and editing the message) Then force push your branch: git push -f <repo-alias> master

claudep commented 3 years ago

Oh sorry, now I realize that you have several commits already. So you should use some rebase magic to do that.

git rebase -i HEAD~3 would allow you to re-edit the commit message. I'd suggest you to study a bit the rebase capabilities, as it could surely be useful in your projects. Of course, rebasing should be done with caution and only on "working" branches.

mpasternak commented 3 years ago

I did rebase and a force-push. Does it look okay for you?