jazzband / tablib

Python Module for Tabular Datasets in XLS, CSV, JSON, YAML, &c.
https://tablib.readthedocs.io/
MIT License
4.58k stars 589 forks source link

Add newline to StringIO #518

Closed matthewhegarty closed 2 years ago

matthewhegarty commented 2 years ago

This is a fix for #517. Adding the newline kwarg to StringIO handles interpreting the LF char.

https://docs.python.org/3/library/functions.html#open-newline-parameter

codecov[bot] commented 2 years ago

Codecov Report

Merging #518 (12aace0) into master (d9a4a97) will increase coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Current head 12aace0 differs from pull request most recent head 10bd273. Consider uploading reports for the commit 10bd273 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
+ Coverage   90.82%   90.84%   +0.01%     
==========================================
  Files          28       28              
  Lines        2660     2664       +4     
==========================================
+ Hits         2416     2420       +4     
  Misses        244      244              
Impacted Files Coverage Δ
src/tablib/utils.py 100.00% <100.00%> (ø)
tests/test_tablib.py 98.62% <100.00%> (+<0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d9a4a97...10bd273. Read the comment docs.

claudep commented 2 years ago

Thanks! May I ask you to also add a line in HISTORY.md?

matthewhegarty commented 2 years ago

Have updated HISTORY as requested.