peymanslh commented 1 year ago

I ran flake8 and fixed all issues raised by it. In my next PR, I will add flake8 to pre-commit (I can't send that PR before this because pre-commit runs by tox and breaks CI)

The change in isort version is because of a bug that fixed in the latest release. link - issue link

codecov[bot] commented 1 year ago

Codecov Report

Merging #536 (e28930a) into master (b2be12e) will decrease coverage by 0.03%. The diff coverage is 90.00%.

:exclamation: Current head e28930a differs from pull request most recent head f2b65c9. Consider uploading reports for the commit f2b65c9 to get more accurate results

@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
- Coverage   91.16%   91.13%   -0.03%     
==========================================
  Files          28       28              
  Lines        2670     2674       +4     
==========================================
+ Hits         2434     2437       +3     
- Misses        236      237       +1

Impacted Files	Coverage Δ
src/tablib/formats/_latex.py	`100.00% <ø> (ø)`
src/tablib/formats/_xlsx.py	`96.96% <ø> (-0.04%)`	:arrow_down:
src/tablib/formats/_rst.py	`95.12% <75.00%> (+0.03%)`	:arrow_up:
src/tablib/packages/dbfpy/record.py	`76.38% <80.00%> (+0.33%)`	:arrow_up:
src/tablib/packages/dbfpy/fields.py	`71.27% <87.50%> (ø)`
src/tablib/packages/dbfpy/header.py	`83.16% <90.00%> (-0.68%)`	:arrow_down:
src/tablib/core.py	`85.01% <100.00%> (ø)`
src/tablib/formats/_dbf.py	`100.00% <100.00%> (ø)`
src/tablib/formats/_ods.py	`98.18% <100.00%> (ø)`
src/tablib/packages/dbfpy/dbf.py	`68.75% <100.00%> (ø)`
... and 8 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

peymanslh commented 1 year ago

@claudep @hugovk Thanks for your review, I applied your suggestion and squashed my commits. Is there anything I need to change?

jazzband / tablib

Fix linting issues raised by flake8 #536

Codecov Report