jazzband / tablib

Python Module for Tabular Datasets in XLS, CSV, JSON, YAML, &c.
https://tablib.readthedocs.io/
MIT License
4.58k stars 589 forks source link

Add <tbody> tags to html output #539

Closed krowbar closed 1 year ago

krowbar commented 1 year ago

Resolves jazzband/tablib#538

Wrap data rows in <tbody> tags to fix minifying (with a header row) when dropping optional end tags. Otherwise the entire table renders with <thead> styling.

claudep commented 1 year ago

Looks like tests need to be adapted.

codecov[bot] commented 1 year ago

Codecov Report

Merging #539 (8d5e28b) into master (8b9cf49) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #539      +/-   ##
==========================================
+ Coverage   91.13%   91.15%   +0.01%     
==========================================
  Files          28       28              
  Lines        2674     2680       +6     
==========================================
+ Hits         2437     2443       +6     
  Misses        237      237              
Impacted Files Coverage Δ
src/tablib/formats/_html.py 100.00% <100.00%> (ø)
tests/test_tablib.py 98.66% <100.00%> (+<0.01%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more