Closed claudep closed 1 year ago
Nice! I think we can now delete
setup.py
completely?
I read that it might be useful for some older environments, but if you think it's not needed, we can remove it too (and see if we get complaints :wink:).
Let's try without the stub setup.py
.
https://setuptools.pypa.io/en/latest/userguide/quickstart.html#basic-use says (emphasis added):
We also recommend users to expose as much as possible configuration in a more declarative way via the pyproject.toml or setup.cfg, and keep the setup.py minimal with only the dynamic parts (or even omit it completely if applicable).
And https://setuptools.pypa.io/en/latest/userguide/quickstart.html#development-mode says:
Prior to pip v21.1, a setup.py script was required to be compatible with development mode. With late versions of pip, projects without setup.py may be installed in this mode.
If you have a version of pip older than v21.1 or is using a different packaging-related tool that does not support PEP 660, you might need to keep a setup.py file in file in your repository if you want to use editable installs.
If anyone needs editable installs, I think it's fair enough to require modern pip (= less than two years old).
We can always add the stub back if it's really needed.
OK, fine. setup.py removed!
Codecov Report
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more