jazzband / tablib

Python Module for Tabular Datasets in XLS, CSV, JSON, YAML, &c.
https://tablib.readthedocs.io/
MIT License
4.56k stars 588 forks source link

fix(ods): None values are not displayed as string #566

Closed hoccau closed 8 months ago

hoccau commented 8 months ago

Actually, None values are converted in string in an ODS sheet (so 'None' string is displayed in cells). This fill a cell empty value in case of None. Sorry for not providing test : I see that ODS is tested only globally. It could be improved later :) Thanks!

codecov[bot] commented 8 months ago

Codecov Report

Merging #566 (aec46cb) into master (8e2004c) will increase coverage by 0.00%. Report is 1 commits behind head on master. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #566   +/-   ##
=======================================
  Coverage   92.40%   92.41%           
=======================================
  Files          28       28           
  Lines        2938     2941    +3     
=======================================
+ Hits         2715     2718    +3     
  Misses        223      223           
Files Coverage Δ
src/tablib/_vendor/dbfpy/dbf.py 68.75% <ø> (ø)
src/tablib/_vendor/dbfpy/dbfnew.py 97.67% <ø> (ø)
src/tablib/_vendor/dbfpy/fields.py 71.27% <ø> (ø)
src/tablib/_vendor/dbfpy/header.py 83.16% <ø> (ø)
src/tablib/_vendor/dbfpy/record.py 76.38% <ø> (ø)
src/tablib/_vendor/dbfpy/utils.py 90.32% <ø> (ø)
src/tablib/formats/_dbf.py 100.00% <100.00%> (ø)
src/tablib/formats/_ods.py 99.24% <100.00%> (+0.01%) :arrow_up:
tests/test_tablib.py 98.84% <100.00%> (+<0.01%) :arrow_up:
tests/test_tablib_dbfpy_packages_fields.py 100.00% <100.00%> (ø)
... and 1 more

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

claudep commented 8 months ago

I would suggest waiting for PR #568 to be merged, then you can rebase and take advantage of the new import functionality to complement the tests.

hoccau commented 8 months ago

I would suggest waiting for PR #568 to be merged, then you can rebase and take advantage of the new import functionality to complement the tests.

ok, fine.