jazzband / tablib

Python Module for Tabular Datasets in XLS, CSV, JSON, YAML, &c.
https://tablib.readthedocs.io/
MIT License
4.56k stars 588 forks source link

Fixes #572 - Allow appending rows after a dynamic column was inserted #573

Closed claudep closed 6 months ago

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (92a7535) 92.41% compared to head (ec9c861) 92.47%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #573 +/- ## ========================================== + Coverage 92.41% 92.47% +0.06% ========================================== Files 28 28 Lines 2941 2965 +24 ========================================== + Hits 2718 2742 +24 Misses 223 223 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

claudep commented 6 months ago

Thanks for the review, but I'd like to work on it some more, specifically to allow the use case of people inserting complete new rows with dynamic values already calculated, and add some docs about it.

claudep commented 6 months ago

A second quick review would be great (also for wording).