search

jazzband / tablib

Python Module for Tabular Datasets in XLS, CSV, JSON, YAML, &c.
https://tablib.readthedocs.io/
MIT License
4.6k stars 592 forks source link

Add optional requirement specifier "html" back #589

Closed mdellweg closed 6 months ago

mdellweg commented 6 months ago

Removing such a specifier should be considered a breaking change and be postponed to the next major release, because pip install tablib[html] fails on this. Since there are no actual dependencies to consider, an empty list is put behind that key.

fixes #588

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.66%. Comparing base (0e68ed8) to head (e8994fa).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #589 +/- ## ======================================= Coverage 92.66% 92.66% ======================================= Files 28 28 Lines 2958 2958 ======================================= Hits 2741 2741 Misses 217 217 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hugovk commented 6 months ago

Please could you also add this as a bugfix in https://github.com/jazzband/tablib/blob/master/HISTORY.md in this PR, with 3.6.1 and today's date, and I'll make a new release?

hugovk commented 6 months ago

Thanks!

hugovk commented 6 months ago

Thanks, this has been released: https://pypi.org/project/tablib/3.6.1/

mdellweg commented 6 months ago

Thank you so much for pushing it through.