search

jazzband / wagtailmenus

An app to help you manage and render menus in your Wagtail projects more effectively
MIT License
398 stars 138 forks source link

Django v3.0 has removed private Python 2 compatibility APIs, one of them is django.utils.six #357

Closed narun4sk closed 4 years ago

narun4sk commented 4 years ago

The latest version of Wagtail is compatible with Django 2.1, 2.2 and 3.0, however the wagtailmenus was not, at least because of the #354.

codecov[bot] commented 4 years ago

Codecov Report

Merging #357 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #357   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files          88       88           
  Lines        2829     2829           
=======================================
  Hits         2776     2776           
  Misses         53       53
Impacted Files Coverage Δ
wagtailmenus/models/menus.py 97.9% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a93857...e2bed66. Read the comment docs.

ababic commented 4 years ago

Hi @narun4sk, and thank you for the contribution. Seeing as wagtailmenus no longer supports Python 2, it might be better to evaluate where six is being used and see if it can be eliminated all together. This would be preferred to adding additional dependencies.

ababic commented 4 years ago

Superseded by #358