search

jazzband / wagtailmenus

An app to help you manage and render menus in your Wagtail projects more effectively
MIT License
398 stars 138 forks source link

Release prep/3.0.2 #369

Closed sekanitembo closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #369 into master will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
+ Coverage   98.12%   98.14%   +0.01%     
==========================================
  Files          88       88              
  Lines        2828     2855      +27     
==========================================
+ Hits         2775     2802      +27     
  Misses         53       53
Impacted Files Coverage Δ
wagtailmenus/__init__.py 76.47% <100.00%> (ø)
wagtailmenus/utils/misc.py 92.98% <100.00%> (-3.25%) :arrow_down:
wagtailmenus/utils/tests/test_misc.py 100.00% <100.00%> (ø)
wagtailmenus/utils/version.py 100.00% <0.00%> (+15.38%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ab5931...55a723a. Read the comment docs.

ababic commented 4 years ago

@sekanitembo Don't sweat the codecov failure :) It's only complaining because the new code isn't run in the version that is used to generate the coverage report. I'm happy to ignore the warning and merge anyway.

sekanitembo commented 4 years ago

@ababic Happy to help! Thanks for letting me pitch in. I made all the changes you mentioned in the review, and am happy to do what's needed to comply with your usual practice of separating compatibility/release PRs. I was just following the docs on releases, so I can add an issue for adding a compatibility PR to the docs, too, if you want.

ababic commented 4 years ago

@sekanitembo yes, that particular bit of documentation is for maintainers really (I don't expect contributors to prepare releases, or even add release notes), but I appreciate you taking the initiative. I suppose you've saved me a job really :)