search

jazzband / wagtailmenus

An app to help you manage and render menus in your Wagtail projects more effectively
MIT License
398 stars 138 forks source link

Add compatibility for Django 4.1 #429

Closed jnpkr closed 2 years ago

jnpkr commented 2 years ago

django.utils.safestring.mark_safe now preserves lazy objects in version 4.1+ so this commit sets the mark_safe_lazy function conditionally for compatibility

janbaykara commented 2 years ago

Thanks for this @jnpkr. Could @ababic or @MrCordeiro review and merge this in? Very simple PR!

codecov[bot] commented 2 years ago

Codecov Report

Merging #429 (6bf3496) into master (100d90c) will decrease coverage by 0.03%. The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
- Coverage   98.24%   98.21%   -0.04%     
==========================================
  Files          89       89              
  Lines        3021     3025       +4     
==========================================
+ Hits         2968     2971       +3     
- Misses         53       54       +1
Impacted Files Coverage Δ
wagtailmenus/models/menus.py 97.82% <80.00%> (-0.17%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

MrCordeiro commented 2 years ago

Since this was solved by #432, so I'm closing this one