search

jazzband / wagtailmenus

An app to help you manage and render menus in your Wagtail projects more effectively
MIT License
398 stars 138 forks source link

🔖 (release): v4.0.0rc1 #480

Closed schlich closed 8 months ago

dkirkham commented 8 months ago

Hi @schlich, thanks for merging #472, but it wasn't quite ready... as well as the docs, there are some packaging and testing changes. Many are in my local repo, so I'll now create separate PRs for those.

There are also some breaking changes, impacting anyone who has customised the admin, which would suggest we should be going for v4.0 rather than v3.2.0.

schlich commented 8 months ago

Thanks for the update @dkirkham -- the merge doesn't trigger a release or anything, and as far as I'm concerned as a maintainer if it passes CI it is safe to merge to main -- if you think the merge is in a broken state then let's make sure we capture those failure states in tests.

Thanks for the major release warning -- I had questions about whether this might be a minor or major release. Can you point me to some code related to the breaking change? Let's make sure we have a migration process documented.

Let me know if there's anything I can do to help with the packaging/testing changes you mention (maybe this resolves my comments above).

MrCordeiro commented 8 months ago

On that note, @schlich please allow at least one day between opening a PR and merging it so that it gets the chance to be reviewed by other people.

This is what we've been following in this project for other PRs.

dkirkham commented 8 months ago

@schlich, see the comment at https://github.com/jazzband/wagtailmenus/pull/472#discussion_r1460754040. I have mostly documented this breaking change in the release notes, which I haven’t had a chance to commit - a bit more checking to do first.

MrCordeiro commented 8 months ago

@dkirkham, I think we are close to a release, right? :D

dkirkham commented 8 months ago

@MrCordeiro and @schlich, I'm happy with my changes, now that they are merged. I have retested with a full set of tests using tox, and then within my own project by installing the master branch with pip. All good.

As far as I can see, this PR needs to have:

May I leave that to you or the other contributors?

schlich commented 8 months ago

Yep i can take care of that this evening, rock on