Open naturallymitchell opened 5 years ago
I think it's being used in http authentication
yea, but that commit I referenced doesn't even seem to put it to use if so, could you switch it to the bindings' function
But it is being used, I don't know what that commit is but you can look at the source code and see it required: init.lua line 19
But if there is a binding function, we should use that one instead
that it's required isn't important I don't see anywhere it's even used when you added it, you didn't even seem to make use of it the generate auth function just uses a math function
I obviously added it because I needed it, if it's not being used in lighttouch-base it's in some package, I don't know where, but I was countering your point that that commit removed the require because it is being required currently, and so it may be used.
And anyway I already agreed with you about removing it and using the binding's function
Oh, there is no binding function yet? I was confusing it with heck functions in the other issue. In that case this is unnecessary, the library is not doing any harm
Oh, there is no binding function yet?
you misread
this is now breaking it
https://github.com/foundpatterns/lighttouch-base/blob/6c2107c32bf6db4149d64f1874c6ca865d05f09d/init.lua#L19
if it's in use anywhere, it can be replaced by torchbear's base64 functions