search

jazzdotdev / jazz

The Scripting Engine that Combines Speed, Safety, and Simplicity
Apache License 2.0
146 stars 11 forks source link

move declarations to separate file #153

Open naturallymitchell opened 5 years ago

naturallymitchell commented 5 years ago

https://github.com/foundpatterns/torchbear/blob/fdb47a2150261c1869b39e364a90ac60d70f6d3f/src/lib.rs#L2-L48

would it be possible to move extern crate declarations to declarations.rs or better? we should be able to Split a module across several files , right?

dariusc93 commented 5 years ago

For now they can stay as is since moving them wont really solve anything and would likely break stuff. I do plan on moving torchbear to 2018 edition which would allow us to remove extern crate for the majority of them, though there is really no gain or loss from switching

dariusc93 commented 5 years ago

With a switch to 2018 edition (https://github.com/foundpatterns/torchbear/issues/154), the extern crate will be optional unless a macro is going to be used then it would need to be included.

naturallymitchell commented 4 years ago

I'd still like to split lib.rs into organized submodules