search

jazzdotdev / jazz

The Scripting Engine that Combines Speed, Safety, and Simplicity
Apache License 2.0
146 stars 11 forks source link

Migrate to 2018 Edition #154

Open dariusc93 opened 5 years ago

dariusc93 commented 5 years ago

While switching doesnt exactly add or remove benefits from using rust, it will allow us to clean up the code base a little, and probably make use of any features (if it is deem necessary).

naturallymitchell commented 5 years ago

why would we do anything differently than use Rust 1.x? doesn't Rust 2018 just represent a milestone in terms of looking at like the last 15 or so Rust releases as one bunch?

naturallymitchell commented 5 years ago

according to https://www.reddit.com/r/rust/comments/ado2hg/what_does_edition_2018_actually_do/ rustc currently defaults to edition 2015, so this would be a good change.

just giving it a try, it had 58 errors and wouldn't compile.

dariusc93 commented 5 years ago

I already have a local branch with the changes. I havent used the cargo fix but you would have errors if you switch without making some of the changes. Ill rebase later on and push the changes

dariusc93 commented 5 years ago

Implemented in https://github.com/foundpatterns/torchbear/commit/3f4fb0c374deec3347caa0a36b7c37e0cf6c6f7a