search

jazzdotdev / jazz

The Scripting Engine that Combines Speed, Safety, and Simplicity
Apache License 2.0
146 stars 11 forks source link

install mp after installing torchbear #166

Open naturallymitchell opened 5 years ago

naturallymitchell commented 5 years ago

164

"Now that you have Torchbear installed, would you like to install Machu Picchu package manager? You can use it to install more apps, safely and easily. To read more about it, check http://github.com/foundpatterns/machu-picchu. If you choose to install now, then running mp --help will show you what to do next with it. Continue with mp install? (Y/n)"

dariusc93 commented 5 years ago

Implemented in https://github.com/foundpatterns/torchbear/commit/a77ae529294bb1879fef25865ed4ed28bfc747a0

naturallymitchell commented 5 years ago

2 things remaining: making Y default and using the above message prompt

naturallymitchell commented 5 years ago

making this optional seems like a waste of effort I'd rather just make it install by default - cargo gets installed by rustup, pip gets installed by python etc..

naturallymitchell commented 5 years ago

let's do this by default, without a prompt. especially because of https://github.com/foundpatterns/torchbear/issues/248

related https://github.com/foundpatterns/torchbear/issues/250

naturallymitchell commented 5 years ago

@dariusc93 could you please take care of this one?

dariusc93 commented 5 years ago

Think it would be best to leave it optional until mp is stable enough.

naturallymitchell commented 5 years ago

stable in what way(s)?

dariusc93 commented 5 years ago

Just general stabilization. Looking at the repo issues there is alot to be done and since mp is in a early state, its usually best to have installation optional until things are more stable.

dariusc93 commented 5 years ago

Weird. I guess I did push a commit to have it install by default in 00a914cff506c3ea36fc56b88ddc55b2f2c9ae54