search

jazzfool / iced_video_player

Video player component for Iced
Apache License 2.0
127 stars 18 forks source link

Custom gstreamer pipelines, VideoPlayer error handling #10

Closed eaglesemanation closed 3 months ago

eaglesemanation commented 3 months ago

Addresses #9. Additionally, auto-detects if pipeline contains sources that are live instead of relying on argument

Custom pipelines are specified as string instead of gst::Pipeline only because creating gst objects requires running gst::init() beforehand. This leads to possible runtime errors instead of compile time, but I feel like that's a reasonable compromise, feel free to disagree.

Also, I made error handling optional and left panicking as a fallback. I'm not sure how I feel about that, maybe it should be required.

jazzfool commented 3 months ago

I'm happy to merge this now, thank you for the PR!