jazzfool / iced_video_player

Video player component for Iced
Apache License 2.0
127 stars 18 forks source link

feat: add optional boolean flag for live video format selection #11

Closed danielmbomfim closed 1 month ago

danielmbomfim commented 1 month ago

In some situations when working with .ts Uris the current live detection mechanism fails to identify the stream as being a live format resulting in errors like Failed to load video: failed to query media duration or position. This merge request introduces an is_live optional boolean flag to the from_pipeline function, allowing for manual selection of whether the video is a live format.

When the flag is set to None, the video format is automatically determined by the existing detection mechanism.

The new flag is only exposed when calling the from_pipeline function directly, ensuring minimal changes to other parts of the API and the default behavior remains unchanged when the flag is None.

jazzfool commented 1 month ago

Merged, thank you!

danielmbomfim commented 1 month ago

Thanks for the merge! Do you have any plans for a new release soon? I'd rather not point to the Git repo in my dependencies.

jazzfool commented 1 month ago

Sure, just released 0.3.0 on crates.io :)