search

jazzhistorydatabase / jhdb-cms

Content management system for jazzhistorydatabase.com
3 stars 0 forks source link

Disable the About JHDB Modal for previews #96

Closed LucasNVarella closed 3 years ago

LucasNVarella commented 4 years ago

We can't just delete the modal from the template either, as we will need it and its php code to work in production.

drnek commented 4 years ago

disable for anyone logged in

matticoli commented 4 years ago

The preview header is different from the prod header (as the former is included via js and the latter is included via php). If we are keeping with this, removing the popup in the portal code may be the easiest solution

Alternatively, we may want to move towards including the global prod header in the preview template

drnek commented 4 years ago

Using the global production header in the preview template should also allow us to include Google analytics tracking.

drnek commented 4 years ago

Otherwise, removing the pop-up entirely from the global contributor portal would be perfect

matticoli commented 4 years ago

Do we want Google Analytics enabled for previews in the contributor portal? I would say probably not. We do want them enabled in production though

drnek commented 4 years ago

it would be interesting to see users around the world contributing in google analytics, but not required. otherwise we see viewers only, which is normal.

matticoli commented 4 years ago

I mean we will see when they visit the page at global.jazzhistorydatabase.com. It will just be disabled in the portal so we don't get false view stats everytime someone clicks preview