search

jazziiRed / nbs-converter

87 stars 13 forks source link

Sneaky trailing comma #2

Closed qexat closed 10 months ago

qexat commented 11 months ago

Hello! I've watched your video, and the project is awesome!

I am currently attempting to add type hints and related stuff, and while I was doing so, I noticed a sneaky trailing comma in this file.

NAME_DISCS = 0,

This makes NAME_DISCS a tuple[int] instead of an int (although I think it probably should be a bool), which can lead to unintended behavior/bugs...

Here's what you probably wanted:

NAME_DISCS = 0

I made a PR (#3) to fix that.

Have a good day!

jazziiRed commented 10 months ago

Good catch, thank you. I'm not sure how that comma got in there

jazziiRed commented 10 months ago

PR merged