jazziiRed / nbs-converter

92 stars 14 forks source link

Extra code to properly set empty instruments to air blocks instead of completly ignoring it. #4

Closed miclol closed 1 year ago

miclol commented 1 year ago

With the current code, new schematics will not overwrite past instruments in a song if it is not used in the new song.

  1. Load Perry The Platypus Theme Schematic into the world. 2023-09-04_01 58 19

  2. Try to load Tetris A Theme with the current code. 2023-09-04_01 58 56 As you can see, the schematic outline doesn't go past bass drum, essentially leaving the snare drum section and onwards untouched with the Perry the Platypus theme intact, which accidentally mixes the 2 songs together.

  3. Load Tetris A Theme with the modified code. 2023-09-04_01 59 22 The schematic outline now properly extends all the way to the end, erasing all traces of the Perry the Platypus Theme from the Tetris A Theme.

Schematics used: schems.zip

Tested on Litematica and WorldEdit.