search

jb-1980 / khanimport

Use Khan Academy's API to import progress into Moodle gradebook
5 stars 1 forks source link

Grade syncer needs update for Moneyskill revision #4

Closed kenburbank closed 7 years ago

kenburbank commented 7 years ago

The front end of moneyskill has changed. This was the previous url that returns an error:

https://lms.moneyskill.org/teachers/login.cfm?so=1

https://lms.moneyskill.org/teachers

It appears that they did away with teacher numbers and renumbered all the classes. Here are links to all of the gradebooks.

MFL A (1242): https://lms.moneyskill.org/teachers/class/1016/students/grades MFL B (1253): https://lms.moneyskill.org/teachers/class/1017/students/grades Fin Lit 1 (1292): https://lms.moneyskill.org/teachers/class/1019/students/grades Fin Lit 2 (1305): https://lms.moneyskill.org/teachers/class/1020/students/grades

@jb-1980 Hope it's a relatively quick fix. Please keep me informed. Thanks!

kenburbank commented 7 years ago

I changed the Moneyskill course ID numbers in Grade Syncer to the new ones, but won't run. @jb-1980 Perhaps just the new login protocol noted above?

jb-1980 commented 7 years ago

I had to refactor it to use the new endpoints, which also require authentication. But it should be working now. It successfully ran Financial Literacy 1 1708. I did not actually do any spot checking to make sure the grades updated, but I am sure you can take it from there.

kenburbank commented 7 years ago

Thanks, but I didn't mean for you to do it on your break, but I appreciate it.

What is the login and password for your tracker?

Ken Burbank

Director of Math Education, Sequoia Choice

Phone: 480-254-7698

Virtual classroom link: https://zoom.us/j/6937843649http://www.tinyurl.com/sequoiachoicemath

[1468527002671_sequoia-choice-logo_tree_200r1.png]

Our Mission is to provide a caring environment of high expectations, individualized attention, and great teaching via a distance learning delivery system that is sufficiently adaptable to help K-12 students in traditional and non-traditional educational settings achieve their maximum academic potential and life goals.

AMDG

From: Joseph Gilgen notifications@github.com Sent: Wednesday, October 11, 2017 12:52 PM To: jb-1980/khanimport Cc: Ken Burbank; Author Subject: Re: [jb-1980/khanimport] Grade syncer needs update for Moneyskill revision (#4)

I had to refactor it to use the new endpoints, which also require authentication. But it should be working now. It successfully ran Financial Literacy 1 1708. I did not actually do any spot checking to make sure the grades updated, but I am sure you can take it from there.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/jb-1980/khanimport/issues/4#issuecomment-335928046, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AV5xGMNVZEVViKcL9YopE-8UtnU1wngYks5srRx-gaJpZM4P1d5N.

kenburbank commented 7 years ago

Hi @jb-1980 The Moneyskill import isn't working. Case: Trestyn Thompson #81311 Course ID #1292 Moneyskill course 1019

Syncer says it ran with cron job overnight (10/18) but student has two scores from yesterday not posted trestyn

kenburbank commented 7 years ago

I just ran grade syncer for MFL A gradebook # 1242 (at 9:45 on 10/23). It takes a while and says it ran, but no updated grades.

jb-1980 commented 7 years ago

Curious, are you receiving the emails about unmatched students? It appears that those warnings are being sent to the sequoiachoicemath account, not to the personal emails. I mention it, because it appears that everything is syncing as expected, but there are a large number of students who don't match up. It may be that those students are not receiving updated grades because their is a mismatch in their names between ELMS and Moneyskill. I am still trying to investigate further.

jb-1980 commented 7 years ago

Found the bug. It was casting a key as an integer instead of a string, and thus messed up the look up. Anyways, it should be working now.

kenburbank commented 7 years ago

Ah, I didn't know they went to that email. Yes, there are error messages there.

Here is one for math for financial literacy A. Note three things: Possible points is now a student name it is searching for. This list is not the full class, but it must time out or quit. The names names are First Last, but I enter them as Last, First. Before they changed Moneyskill to the new format, was this how the names were presented?

kenburbank commented 7 years ago

Didn't paste in the sample

The following students did not have a match from ELMS: Possible Points Dyanicia Santamaria Esmeralda Soto Avendado Serge Baraka Samantha Bernice Salinas Clarissa Chamberlain Gerson Chonay Yool

kenburbank commented 7 years ago

No joy. I ran a test of the grade syncer and no update. It was a 90 on moneyskill #1 for Ana Coronado Lopez in Fl 2 gradebook # 1305. I will leave the grade blank in the gradebook to see if the cron job posts it tonight.

jb-1980 commented 7 years ago

Doh! I feel like a fool. I have been butting my head against this for hours, and just realized that I forgot to push the changes to the production server. So of course you will have no joy, because the code wasn't there yet.

I just checked with Ana's grade, and everything is copacetic. You can reopen if you continue to see issues.