jb0s / blockgame-enhanced

Fabric mod that fixes a lot of client-side issues and adds a ton of quality-of-life features for the Blockgame server.
MIT License
29 stars 15 forks source link

Unable to rename most items in anvil. #16

Open TheInfamousAlk opened 10 months ago

TheInfamousAlk commented 10 months ago

Describe the bug When the blockgame mod is enabled, certain items cannot be renamed in the anvil. This includes book and quills, cobblestone, and many more. Previously renamed items can be renamed again.

When attempting to rename an item, any added or removed characters are reset immediately while typing.

I have also replicated this bug when using the MCMMO durability viewer mod without the blockgame enhanced mod and vice versa. In other words, both mods independently cause this bug. In addition, both mods add this specific function: when an item has multiple charges, (such as a potion or pickled phalanges) both mods add a number to represent remaining charges to the item texture.

As such, I think the bug stems from this specific feature inside blockgame enhanced. To be clear: even without MCMMO durability viewer, using only blockgame enhanced, cloth config, and fabric API, the bug is present. Which is why I am reporting it here.

In addition, this bug only started between 1/6 and 1/8, with no mod changes on my end, so it may originally stem from a change to the blockgame server during this time that is incompatible with the blockgame enhanced mod.

Desktop (please complete the following information):

jb0s commented 10 months ago

Weird! Thanks for the report. Will investigate.

jb0s commented 10 months ago

Does this bug happen without the mod? What items are you trying to rename? I cannot reproduce this

TheInfamousAlk commented 10 months ago

It doesn't happen at all without the mod. It doesn't happen in pure vanilla, and even when I enabled all ~20 of my regular-use mods EXCEPT blockgame enhanced, it didn't happen. I was specifically trying to rename a book and quill, but I also tested with cobblestone, prismarine shard, and a gold ingot. I also had user "blanksuspect" try it, and he had the exact same results, happens with BGE and doesn't happen without.

TheInfamousAlk commented 10 months ago

It's not super detrimental, when we need to do our weekly book renaming I just disable BGE then rename the books then re-enable BGE, just takes a couple clicks and 2 re-launches.