search

jbagg / QtZeroConf

Qt wrapper class for ZeroConf libraries across various platforms.
Other
69 stars 51 forks source link

Fix clang compiler errors and warnings #31

Closed mincequi closed 4 years ago

mincequi commented 4 years ago

Fixed some warnings and errors when compiling with clang on OSX.

Btw. which IDE do you use? QtCreator? Which code style do you apply? I could not find something appropriate. What do you think about QtCreators default style? (using spaces instead of tabs, use one-true-brace-style).

mincequi commented 4 years ago

Ok, I will just do functional changes.

You also do the member initialization in the Resolver class within bonjour_p.h. So, we should be fine.

I will do an update on this PR.

jbagg commented 4 years ago

Would you mind sending me a patch of this change instead of using github's pull request? I rebased master and I'm not sure what the github tools will do to the history. Git will still show you as the committer when I sign off.

git format-patch -n HEAD^

mincequi commented 4 years ago

0001-Fix-clang-compiler-errors-and-warnings.patch.zip

Github behaves the same here as regular git: when you rebase, my changes get applied on top (making them the most recent commit).

See attached patch.

jbagg commented 4 years ago

Manually signed off on this change in commit 5c4b