search

jbagg / QtZeroConf

Qt wrapper class for ZeroConf libraries across various platforms.
Other
70 stars 51 forks source link

bonjour-sdk: fix gcc compilation on windows #38

Closed rumengb closed 4 years ago

rumengb commented 4 years ago

QtZeroconf fails with type definition errors with GCC on Windows. So i ignore them if the compiler is GCC.

jbagg commented 4 years ago

This file is from the apple bonjour sdk. I wounder if a define is not set correctly. It is unlikely to be a bug.

rumengb commented 4 years ago

It is up to you. I use QtZeroConf on three platforms Linux Mac and Windows and on windows it does not compile with gcc any more. It used to work with previous SDK files. I assume Apple does not support GCC on windows, but it was easy fix and it works fine. So i decided to give back as many can benefit from this fix...

jbagg commented 4 years ago

Right, I just need to know if it is Apples issue or mine. CommonServices.h comes from https://opensource.apple.com/tarballs/mDNSResponder/ from the mDNSShared folder. Can you try and compile something that uses CommonServices.h and see if you get the same error? Maybe Clients/BonjourExample

rumengb commented 4 years ago

i can not... they only provide Vc and xcode projects. copiling it with gcc fails... maybe I am missing something but issues are more serious than this one. Tried to compile it on Linux too.. fails miserably... however i looked at the source code. they do not include stdint.h for windows architecture. and it enters this section. then when you include stdint.h in your project it fauls with soube definition. So I will make a better PR. Which if I am correct should work. but still the issue is in CommonServices.h. Wait a bit

rumengb commented 4 years ago

I was right... will make another one...