search

jbagg / QtZeroConf

Qt wrapper class for ZeroConf libraries across various platforms.
Other
69 stars 51 forks source link

fix for gcc compilation on windows #39

Closed rumengb closed 4 years ago

FMeinicke commented 4 years ago

Hey @jbagg, I've also had the issue that this PR addresses. Would you be willing to merge this into master?

jbagg commented 4 years ago

I don't like fixing this in QtZeroConf as this file comes from Apple's SDK. When I bring in newer SDKs, I'm sure I'll forgot about this modification.

FMeinicke commented 4 years ago

Oh, ok. Well, is there anyway we could bring this fix into Apple's SDK directly? So that the next time you update the SDK this issue has already been resolved.

But thank you for merging, still :)

rumengb commented 4 years ago

Do not worry :) I will make another PR when my build fails :)

On Fri, Oct 30, 2020, 10:32 AM Florian Meinicke notifications@github.com wrote:

Oh, ok. Well, is there anyway we could bring this fix into Apple's SDK directly? So that the next time you update the SDK this issue has already been resolved.

But thank you for merging, still :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jbagg/QtZeroConf/pull/39#issuecomment-719412833, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5EZBKA7XZKN6YYLD3TGKDSNJ22DANCNFSM4QO6SE7A .