Add CMake support

[FMeinicke]

Hi, I'm currently working on a larger project that needs cross-platform zeroconf support. However, I'm using CMake as build system so I thought it would nice to be able to integrate QtZeroConf via CMake. I found that cor3ntin already did some modifications and added a basic CMakeLists.txt (unfortunately, he deleted his fork of the repo). This was a really good starting point for me. I built on top of that and just modernized the CMakeLists a bit and fixed some stuff that didn't work properly.

What this PR introduces is:

• a QtZeroConf CMake project that builds either a shared or a static library (configurable through the standard BUILD_SHARED_LIBS variable) on Windows (tested), Linux (tested), MacOS (not tested) and Android (not tested)
• an installable CMake target for QtZeroConf
• another CMake project for the example application that uses the QtZeroConf target from the main CMake project

[jbagg]

HI Thank you for this new feature! There is an unrelated change included in qzeroconfservice.h. Is there a way I can just merge the other three files in your pull request? Jon

[FMeinicke]

Oops. Just saw that. That must have been my auto-format. I'm gonna update the PR later and remove that unrelated change.

[FMeinicke]

Hi, so I removed that change now. However, it wasn't my auto-format as I suspected yesterday (I was using GitHub's mobile app so I didn't read the code correctly). Instead, I had to add the Q_ZEROCONF_EXPORT macro to the operator<< in qzeroconfservice.h. Otherwise, I would be getting a linker error on Windows because the debug operator wouldn't be properly exported in a DLL.

I can see how this might seem unrelated to this particular PR for you. However, I'd still like to see add change. I can make a separate PR if you prefer that.

[jbagg]

ok, Please do a separate PR to add the Q_ZEROCONF_EXPORT to operator<<

On 2020-10-04 4:13 a.m., Florian Meinicke wrote:

Hi, so I removed that change now. However, it wasn't my auto-format as I suspected yesterday (I was using GitHub's mobile app so I didn't read the code correctly). Instead, I had to add the |Q_ZEROCONF_EXPORT| macro to the |operator<<| in qzeroconfservice.h. Otherwise, I would be getting a linker error on Windows because the debug operator wouldn't be properly exported in a DLL.

I can see how this might seem unrelated to this particular PR for you. However, I'd still like to see add change. I can make a separate PR if you prefer that.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jbagg/QtZeroConf/pull/41#issuecomment-703220003, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFEL4ZCKKH3HBVS46ONCWTSJAVBNANCNFSM4SCQB5LQ.