jbaicoianu / threecap

Three.js frame capture system
124 stars 18 forks source link

problem in threecap with reactjs #3

Open eboujlal opened 3 years ago

eboujlal commented 3 years ago

Hello,

I am using threejs to render animation and i want to export this animation to video mp4. When i want to use threecap library, i got an error : TypeError: threecapWEBPACK_IMPORTED_MODULE7default.a is not a constructor

And this is my code :

import THREEcap from 'threecap';

var threecap = new THREEcap({});
threecap.record({
    width: 640,
    height: 480,
    fps: 25,
    time: 10,
    format: 'mp4',
    //canvas: canvasDomElement,   // optional, slowest
    composer: this.renderer.domElement // optional, fastest
}).then(function(video) {
    video.saveFile('myVideo.mp4');
});
rohan-deshpande commented 3 years ago

This package hasn't been bundled properly for use as a module. I've just tried this myself and the only way I could get it to work was to include the lib via a script tag and access via window.THREEcap

eboujlal commented 3 years ago

Thank you i will try it

eboujlal commented 3 years ago

Otherwise i recorded canvas with js vanilla

rohan-deshpande commented 3 years ago

Yah I just published https://www.npmjs.com/package/canvas-to-video which you can try out... I haven't got any tests yet though but give it a go

jbaicoianu commented 3 years ago

You're right, this package was written to be used as a global script. It should be relatively straightforward to convert this to use ES6 modules, I haven't had the time to do so myself though.