search

jbake-org / jbake-gradle-plugin

A Gradle plugin for JBake
Other
46 stars 21 forks source link

cleanup and use jbakeconfig to initialize jbake #64

Closed ancho closed 2 years ago

ancho commented 3 years ago

The upcoming release of jbake includes an update to apache commons2. The plugin should not use the deprecated constructors to initialize the Oven and use a DefaultJBakeConfiguration instead.

I removed the Proxy Implementations to use the WorkerExecutor mechanism instead and therefor deprecated the use of gradle <= 5.6. The Readme already defines gradle 6+ as a requirement.

jonbullock commented 2 years ago

Need to either close this or merge it in prior to the plugin moving to the jbake repo.

aalmiray commented 2 years ago

@ancho I've updated license headers as that made the merge fail on CI. However I've got failures when running tests locally. If the latest action were to fail, could you have a look? https://github.com/jbake-org/jbake-gradle-plugin/actions/runs/1646899607

ancho commented 2 years ago

This seems to be related with the license headers. If I remove those from the template and content files in src/test/resources/example-project the test passes locally.

aalmiray commented 2 years ago

Thank you, that does the trick! 😄

jonbullock commented 2 years ago

Thanks @aalmiray @ancho