search

jbake-org / jbake-maven-plugin

JBake Maven Plugin - NOTE: Code now resides in main JBake repository - https://github.com/jbake-org/jbake
9 stars 15 forks source link

Asciidoctor attributes don't work? #24

Open beikov opened 4 years ago

beikov commented 4 years ago

Switching to JBake 2.6.4 via the following PR lead to Asciidoctor attributes not being processed correctly anymore: https://github.com/Blazebit/jbake-maven-plugin/pull/3

For example, I defined that I want to use source-highlighter=prettify or a specific template directory, but it just isn't used for whatever reason. Is this a known issue?

I debugged into the AsciidoctorEngine but couldn't figure out why it wasn't using the values. AFAICS the values are correctly passed to the Asciidoctor.render() method.

ancho commented 4 years ago

This is a bug or a side effect of the java-maven-plugin. Blazebit is not the official maven-plugin. We have an open PR jbake-org/jbake-maven-plugin/pull/22 which should be compatible with jbake 2.6.4 and fixes issues with asciidoctor.

ancho commented 4 years ago

@jonbullock maybe we should move this ticket to the jbake-maven-plugin repo? I don't seem to have the proper access rights for that.

jonbullock commented 4 years ago

Yeah I agree, I'll move it now.

jonbullock commented 4 years ago

@beikov Is this still an issue? If so, have you got a sample project that demonstrates the issue?