search

jbaldwin / libcoro

C++20 coroutine library
Apache License 2.0
596 stars 61 forks source link

Build conan package in CI and push on release #258

Closed jbaldwin closed 8 months ago

jbaldwin commented 8 months ago

Each PR should build with using conan to install dependencies to verify it can be built via conan then cmake, note issue #251 where it was broken.

The basic flow seems to be:

mkdir build
cd build
conan install .. -g CMakeToolchain -g CMakeDeps
cmake .. -DCMAKE_TOOLCHAIN_FILE=conan_toolchain.cmake
cmake --build .

It appears it is more of a download deps into a special location, then build from there the shared/static libs using cmake (or whatever build tool the project is, for libcoro cmake).

As of writing probably a new ci-conan.yml which would run a build for each major platform (or put a conan build into each ci-.yml file) to make sure that it builds properly via the conan install command followed by cmake.

I'm not particularly familiar with conan so we'll see how this goes!

jbaldwin commented 8 months ago

@uilianries I've spent a little time trying to figure out what exactly conan is and the above is sort of what I've slightly figured out. Am I on the right track for integrating it as a first class citizen into the project?

uilianries commented 8 months ago

@jbaldwin Hello! I could send a PR with this integration!

jbaldwin commented 8 months ago

Yes please, that would be great.