search

jbaldwin / liblifthttp

Safe and easy to use C++17 HTTP client library.
Other
61 stars 16 forks source link

Build failure with gcc13 #151

Closed star-hengxing closed 1 month ago

star-hengxing commented 1 month ago

https://github.com/xmake-io/xmake-repo/actions/runs/10627760358/job/29461413865

inc/lift/http.hpp:19:19: error: found ‘:’ in nested-name-specifier, expected ‘::’
   19 | enum class method : uint8_t
      |                   ^
      |                   ::
inc/lift/http.hpp:19:12: error: ‘method’ has not been declared
   19 | enum class method : uint8_t
      |            ^~~~~~
inc/lift/http.hpp:20:1: error: expected unqualified-id before ‘{’ token
   20 | {
      | ^
inc/lift/http.hpp:32:16: error: ‘method’ was not declared in this scope; did you mean ‘method_put’?
   32 | auto to_string(method m) -> const std::string&;
      |                ^~~~~~
      |                method_put
inc/lift/http.hpp:32:26: error: expected ‘,’ or ‘;’ before ‘->’ token
   32 | auto to_string(method m) -> const std::string&;
      |                          ^~
  > in src/http.cpp

Need to add cstdint header https://gcc.gnu.org/gcc-13/porting_to.html

jbaldwin commented 1 month ago

Hey thanks for opening an issue. I'm on vacation for 2 weeks, but if you want to open a PR I can review and merge if it's simple enough, otherwise it'll have to wait until I'm home.