jbalogh / jingo

An adapter for using Jinja2 templates with Django.
http://readthedocs.org/docs/jingo/en/latest/
BSD 3-Clause "New" or "Revised" License
178 stars 45 forks source link

Fix has_helpers to use proper arguments for 2.7, 3.3 and 3.4 #77

Closed EnTeQuAk closed 8 years ago

EnTeQuAk commented 8 years ago

imp.find_module requires a list of actual directory paths to function properly.

jsocol commented 8 years ago

Thanks! Can you include a test that demonstrates the issue? There should be one in #76.

EnTeQuAk commented 8 years ago

Sure, will update the PR

EnTeQuAk commented 8 years ago

@jsocol I updated the PR with a proper test and another adjustment for python 3

jsocol commented 8 years ago

thanks! just the one small comment, and then would you mind squashing it all down to one commit?

EnTeQuAk commented 8 years ago

Done :smiley:

jsocol commented 8 years ago

Thanks @EnTeQuAk! I'm going to do a little clean up today and cut a release

EnTeQuAk commented 8 years ago

Awesome, Thanks!

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling d1fab2b99b847f7e603811dd442259f91ecae3b4 on EnTeQuAk:bugfix/fix-has-helpers into on jbalogh:master.