jbalogh / jingo

An adapter for using Jinja2 templates with Django.
http://readthedocs.org/docs/jingo/en/latest/
BSD 3-Clause "New" or "Revised" License
178 stars 45 forks source link

Compat for Django 1.9 and 1.10 #81

Open thomasgoirand opened 8 years ago

thomasgoirand commented 8 years ago

Hi there!

I'm the package maintainer of python-jingo in Debian. I maintain it, because it's a build-dependency of python-django-compressor, which is itself used by OpenStack Horizon (the OpenStack dashboard), and I maintain all packages for OpenStack in Debian.

As we're going to ship Debian 9 (aka: Stretch, which we will freeze a the end of the year) with Django 1.10, we are already extensively testing and making sure that all of our packages are Django 1.10 ready. Therefore, we're testing them against the beta1 release of Django (which is currently in Debian Experimental).

I have therefore written a few patches for Jingo to support Django 1.10. As much as I can tell, you guys aren't even supporting Django 1.9, which is already old (more than 6 months). I have rebuilt the package in both Django 1.9 and 1.10 env, and all unit tests are passing. Well, all but:

I haven't figured out yet how to fix these in Django 1.9 / 1.10, and I'm not much interested in it, because it looks like only fixing the unit tests themselves. However, if you can come with a patch, I'd love to use it.

Best would be if you could release a new version of Jingo with this pull request, plus the fix of the 3 unit tests above which are failing. In such case, please let me know (I'm zigo on Freenode and OFTC), and I'll make sure your new upstream release ends up in Debian Stretch.

Hoping this pull request helps,

Thomas Goirand (zigo)

jsocol commented 8 years ago

@thomasgoirand as the only remaining maintainer of jingo, I've EOLed the project, as noted in the README. I've moved my projects to django-jinja and recommend others do the same. I won't be doing any additional releases of jingo.

If you're interested in taking over maintenance of the project let me know, I can give you access to PyPI and we can direct people to your fork. Alternatively, you can always fork the project under a new name.

If you do want to pick up maintenance, I'd recommend only supporting currently-supported Django versions, i.e. 1.8–1.10. It helps a lot.