jbangdev / jbang-action

Docker image and Github Action to run jbang scripts
https://jbang.dev
MIT License
40 stars 11 forks source link

chore: use the existing pre-built image instead #24

Closed gastaldi closed 2 years ago

gastaldi commented 3 years ago

When using the jbang-action, GitHub Actions will always build an image because the image here points to the Dockerfile. Pointing to the docker image makes sure it reuses the pre-built image.

See https://stackoverflow.com/a/60679692

image

gastaldi commented 3 years ago

@maxandersen this is something that will make builds using JBang faster

gastaldi commented 3 years ago

The current approach is to build the image everytime: https://github.com/quarkusio/quarkus-extension-catalog/runs/2964129029?check_suite_focus=true

maxandersen commented 3 years ago

I understand the incentive but this can't be the right fix. The fix needs to be part of the jbang release process as otherwise the tag won't match.

I'm surprised this is needed as i thought I already had it using a docker image but maybe I regressed that :/

gastaldi commented 3 years ago

Yeah, you'll need to update it just as you did with the files in https://github.com/jbangdev/jbang-action/commit/c154fbc173658a69d7a880896f607c8732c23f4f

gastaldi commented 3 years ago

Just to be clear: you have a Docker image already published, it is just not used because the image parameter points to the Dockerfile

maxandersen commented 2 years ago

this was fixed somewhat recently .

gastaldi commented 2 years ago

Oh, happy that it uses the same fix I proposed. Turns out that was the correct fix after all, what a relief :)

maxandersen commented 2 years ago

Yeah. Just needed fixing the main source repo templates rather than in this repo that is just a "compiled" version.