Closed gastaldi closed 2 years ago
@maxandersen this is something that will make builds using JBang faster
The current approach is to build the image everytime: https://github.com/quarkusio/quarkus-extension-catalog/runs/2964129029?check_suite_focus=true
I understand the incentive but this can't be the right fix. The fix needs to be part of the jbang release process as otherwise the tag won't match.
I'm surprised this is needed as i thought I already had it using a docker image but maybe I regressed that :/
Yeah, you'll need to update it just as you did with the files in https://github.com/jbangdev/jbang-action/commit/c154fbc173658a69d7a880896f607c8732c23f4f
Just to be clear: you have a Docker image already published, it is just not used because the image
parameter points to the Dockerfile
this was fixed somewhat recently .
Oh, happy that it uses the same fix I proposed. Turns out that was the correct fix after all, what a relief :)
Yeah. Just needed fixing the main source repo templates rather than in this repo that is just a "compiled" version.
When using the jbang-action, GitHub Actions will always build an image because the image here points to the Dockerfile. Pointing to the docker image makes sure it reuses the pre-built image.
See https://stackoverflow.com/a/60679692