search

jbangdev / jbang-idea

IntelliJ IDEA plugin for JBang
https://plugins.jetbrains.com/plugin/18257-jbang
MIT License
20 stars 9 forks source link

External library name is always jbang #45

Closed nandorholozsnyak closed 2 years ago

nandorholozsnyak commented 2 years ago

After the jbang script is being syncronized it has the name jbang for the dependency collector thing, but if a multi module project is being used it could be a bit "annoying", is there any way to append the name of the module as a prefix for the dependency collector?

Original: image

Idea: image

maxandersen commented 2 years ago

would it not be more right to name it after the root file the classpath library was made?

nandorholozsnyak commented 2 years ago

would it not be more right to name it after the root file the classpath library was made?

So you say if it has three files for example, App.java, AnotherApp.java and forexmaple TestApp.java, then should it be called App-jbang? It can work yeah, but what about the AnotherApp.java or maybe it could be named after the folder that contains all the files.

For me the module's name make sense to use, but I can imagine that it could/should be configurable. One module/folder can have multiple JBang scripts (depends on the use cases of course), so with that in my how would you infer that name?

linux-china commented 2 years ago

Closed by 0.18.0

maxandersen commented 2 years ago

Fixed how @linux-china ?

maxandersen commented 2 years ago

Ah it was done some weeks ago. Was looking for recent PRs and couldn't find jt :)

Still thinks this should be named per source file rather than per module but current behavior works for now.