search

jbangdev / jbang-vscode

JBang extension for Visual Studio Code
MIT License
12 stars 2 forks source link

feat: Trying some TextMate Grammar for JBang directives #119

Closed fbricon closed 9 months ago

fbricon commented 9 months ago

I have no idea what I'm doing. It's most likely wrong, certainly suboptimal, but looks half decent in java files Can't figure out how to enable it properly in build.jbang files though.

Screenshot 2024-02-17 at 17 10 15 Screenshot 2024-02-17 at 17 11 01

@maxandersen WDYT?

fbricon commented 9 months ago

@hopehadfield, @angelozerr if you know how to make it right, lemme know ;-)

angelozerr commented 9 months ago

I am not a big expert ,wih textmate.

I dont unterstand what is the problem?

fbricon commented 9 months ago

For starters, the code looks wrong to me. Now if you try the vsix unzipped from the CI build, and create a build.jbang file containing 

///usr/bin/env jbang "$0" "$@" ; exit $?
//DEPS info.picocli:picocli:4.6.1
//DEPS org.slf4j:slf4j-simple:1.7.30
//DEPS org.slf4j:slf4j-api:1.7.30

you'll see the new syntax highlighting doesn't apply there.

fbricon commented 9 months ago

I'm also unable to apply custom colors to the new scopes

fbricon commented 9 months ago

let's ship what we have for now