search

jbapple / libfilter

High-speed Bloom filters and taffy filters for C, C++, and Java
Apache License 2.0
32 stars 6 forks source link

Fix usage of std::pow #3

Closed mavam closed 2 years ago

mavam commented 2 years ago

Turns out std::pow was lacking a std:: qualification, as well as the proper include.

This failed for me on macOS Big Sur 11.6; this PR fixes the issue.

mavam commented 2 years ago

@jbapple the PR might be obsolete. I saw you committed earlier today to master a fix that adds the include <cmath>, which brings in pow. Was it intentional to go the low-level C route, as opposed to the C++ way?

jbapple commented 2 years ago

@jbapple the PR might be obsolete. I saw you committed earlier today to master a fix that adds the include <cmath>, which brings in pow. Was it intentional to go the low-level C route, as opposed to the C++ way?

Nope, it was unintentional. Thank you!