search

jbarkis / Carousel

0 stars 0 forks source link

[iOS Bootcamp] Project 2 - Review my app #1

Open jbarkis opened 10 years ago

jbarkis commented 10 years ago

My Carousel app is complete. Please review. /cc @thecodepath

tonysherbondy commented 9 years ago

Great job getting through the requirements for this and onto the optional sign-up.

One concern that I have is that instead of placing the navigation controller behind the main welcome window, you placed two separate navigation controllers to be modally presented after the welcome screen. One way to know whether or not you are placing the navigation controller on the right view is that the first view of the navigation controller should not be one with a back button. The whole point of a back button is to go to a previously presented view in the navigation controller. Let's talk about this if it isn't clear now.

Another thing to note is that the UIAlertView does not require you to pass a UIViewController in as delegate. If you don't care what button the user presses in the alert view then you can safely assign the delegate to nil.