jbaron / cats

Code Assistant for TypeScript
Apache License 2.0
408 stars 66 forks source link

Missing close icon on editor tabs #152

Closed JohnMurga closed 9 years ago

JohnMurga commented 9 years ago

It seems to have disappeared a while ago :-)

dtrillo commented 9 years ago

If you click on the tab after the text, the tab will close. Icon is not needed although you have the funcionality available.

jbaron commented 9 years ago

Which theme and version of CATS are you using?

(it seems indeed to be missing depending on the theme you are using, so just want to make sure)

On 17 May 2015, at 13:02, JohnMurga notifications@github.com wrote:

It seems to have disappeared a while ago :-)

You can view, comment on, or merge this pull request online at:

https://github.com/jbaron/cats/pull/152 https://github.com/jbaron/cats/pull/152 Commit Summary

Missing close icon on editor tabs File Changes

A resource/qx/icon/Oxygen/16/actions/window-close.png https://github.com/jbaron/cats/pull/152/files#diff-0 (0) Patch Links:

https://github.com/jbaron/cats/pull/152.patch https://github.com/jbaron/cats/pull/152.patch https://github.com/jbaron/cats/pull/152.diff https://github.com/jbaron/cats/pull/152.diff — Reply to this email directly or view it on GitHub https://github.com/jbaron/cats/pull/152.

dtrillo commented 9 years ago

i am using "Modern" theme, and I see no close icon (the same as with Classic theme). If you use the other themes, you'll find the icons!

jbaron commented 9 years ago

Thanks for the patch!