jbaron / cats

Code Assistant for TypeScript
Apache License 2.0
409 stars 66 forks source link

TSX support #157

Closed xmehaut closed 8 years ago

xmehaut commented 8 years ago

Hello,

cats is a very nice typescipt iDE. Unfortunately I deelop with react and I need to use TSX ... Is it planned to add this in CATS?

regards

jbaron commented 8 years ago

Had a quick look and should not be too hard to add support since CATS already uses the TS version that supports JSX.

Still to be done:

1) When scanning for files also scan for .tsx extensions. 2) Add the option to enable TSX (in the compiler options sections)

On Mon, Nov 2, 2015 at 6:50 PM, xmehaut notifications@github.com wrote:

Hello,

cats is a very nice typescipt iDE. Unfortunately I deelop with react and I need to use TSX ... Is it planned to add this in CATS?

regards

— Reply to this email directly or view it on GitHub https://github.com/jbaron/cats/issues/157.

xmehaut commented 8 years ago

thanks :)

do you already take into account tsconfig.json otherwise? and if so, with automatic filling each time a new file is added , removed or moved?

2015-11-03 14:07 GMT+01:00 Peter notifications@github.com:

Had a quick look and should not be too hard to add support since CATS already uses the TS version that supports JSX.

Still to be done:

1) When scanning for files also scan for .tsx extensions. 2) Add the option to enable TSX (in the compiler options sections)

On Mon, Nov 2, 2015 at 6:50 PM, xmehaut notifications@github.com wrote:

Hello,

cats is a very nice typescipt iDE. Unfortunately I deelop with react and I need to use TSX ... Is it planned to add this in CATS?

regards

— Reply to this email directly or view it on GitHub https://github.com/jbaron/cats/issues/157.

— Reply to this email directly or view it on GitHub https://github.com/jbaron/cats/issues/157#issuecomment-153347079.

jbaron commented 8 years ago

Right now CATS uses its own config file. It pre-dates the tsconfig file but is very simular in structure and layout. It alos has a GUI to configure it. I would like to move the tsconfig file but a lot is missing that is requried for CATS. So either I have to extend it or have two config files.

On Tue, Nov 3, 2015 at 2:10 PM, xmehaut notifications@github.com wrote:

thanks :)

do you already take into account tsconfig.json otherwise? and if so, with automatic filling each time a new file is added , removed or moved?

2015-11-03 14:07 GMT+01:00 Peter notifications@github.com:

Had a quick look and should not be too hard to add support since CATS already uses the TS version that supports JSX.

Still to be done:

1) When scanning for files also scan for .tsx extensions. 2) Add the option to enable TSX (in the compiler options sections)

On Mon, Nov 2, 2015 at 6:50 PM, xmehaut notifications@github.com wrote:

Hello,

cats is a very nice typescipt iDE. Unfortunately I deelop with react and I need to use TSX ... Is it planned to add this in CATS?

regards

— Reply to this email directly or view it on GitHub https://github.com/jbaron/cats/issues/157.

— Reply to this email directly or view it on GitHub https://github.com/jbaron/cats/issues/157#issuecomment-153347079.

— Reply to this email directly or view it on GitHub https://github.com/jbaron/cats/issues/157#issuecomment-153347657.

xmehaut commented 8 years ago

yes , two files would be right, the CATS's one being specific to CATS

2015-11-03 15:06 GMT+01:00 Peter notifications@github.com:

Right now CATS uses its own config file. It pre-dates the tsconfig file but is very simular in structure and layout. It alos has a GUI to configure it. I would like to move the tsconfig file but a lot is missing that is requried for CATS. So either I have to extend it or have two config files.

On Tue, Nov 3, 2015 at 2:10 PM, xmehaut notifications@github.com wrote:

thanks :)

do you already take into account tsconfig.json otherwise? and if so, with automatic filling each time a new file is added , removed or moved?

2015-11-03 14:07 GMT+01:00 Peter notifications@github.com:

Had a quick look and should not be too hard to add support since CATS already uses the TS version that supports JSX.

Still to be done:

1) When scanning for files also scan for .tsx extensions. 2) Add the option to enable TSX (in the compiler options sections)

On Mon, Nov 2, 2015 at 6:50 PM, xmehaut notifications@github.com wrote:

Hello,

cats is a very nice typescipt iDE. Unfortunately I deelop with react and I need to use TSX ... Is it planned to add this in CATS?

regards

— Reply to this email directly or view it on GitHub https://github.com/jbaron/cats/issues/157.

— Reply to this email directly or view it on GitHub https://github.com/jbaron/cats/issues/157#issuecomment-153347079.

— Reply to this email directly or view it on GitHub https://github.com/jbaron/cats/issues/157#issuecomment-153347657.

— Reply to this email directly or view it on GitHub https://github.com/jbaron/cats/issues/157#issuecomment-153365629.

dtrillo commented 8 years ago

I don't see any problem in having two config files!

jbaron commented 8 years ago

Added some support for TSX. Now it should recognise files with TSX extension as "TypeScript" files. Unfortunately the editor (ACE) doesn't have a mode yet for it. So the default text editor will be started.

jbaron commented 8 years ago

Now also:

So full TSX support in place,

xmehaut commented 8 years ago

Thanks !

2016-01-18 13:51 GMT+01:00 Peter notifications@github.com:

Now also:

  • Updated Ace and fixed so it recognises tax file and applies the TS mode.
  • You can set the compilation target for TSX from within CATS (in case you don't use external build tools)

So full TSX support in place,

— Reply to this email directly or view it on GitHub https://github.com/jbaron/cats/issues/157#issuecomment-172519769.