jbasen / Crestron-Shelly

26 stars 1 forks source link

Relay v4 - Relay0 On Code Problem #23

Closed trentyounggit closed 1 year ago

trentyounggit commented 1 year ago

Hi Jay, not sure if this has been picked up already but in Relay v4 I found a bug where the 'Relay 0 On' input sends a '0' instead of a '1'. See image attached. I have fixed for me at my end in the SIMPL+ module and working now

Screen Shot 2022-11-03 at 5 06 12 pm
jbasen commented 1 year ago

Thanks. I believe that was fixed already in v20. I didn't update the version number of the relay module because it didn't impact the S+ module interface to S+ and I expect that people should just be overwriting their existing modules in their Usrsplus directory with the new ones when a new version is uploaded to GitHub.
If I'm mistaken and it isn't in the v20 version on GitHub then it will be in v21 when I can release that as it is already fixed in the version on my laptop. Thanks again.

jbasen commented 1 year ago

I validated that the v20 release on GitHub includes this fix.

trentyounggit commented 1 year ago

Thanks Jay! Yeah I didn’t update the module with v20 Could have been in there