Exception types: to be or not to be - Githubissues

jbasko / configmanager

Forget about configparser, YAML, or JSON parsers. Focus on configuration. NOT RECOMMENDED FOR USE (2019-01-26)

MIT License

17 stars 5 forks source link

Exception types: to be or not to be #124

Closed jbasko closed 7 years ago

jbasko commented 7 years ago

If user would want to come up with some special logic when a missing config item is requested, they wouldn't be able to at the moment as we throw different exceptions based on how a config item is being requested:

config = Config({'uploads': {}})
config.db  # AttributeError
config['db'] # KeyError
config.uploads.threads # AttributeError
config['uploads']['threads'] # KeyError
config['uploads', 'threads'] # KeyError

[ ] base exception class is needed. It is recommended to not namespace exception class name i.e. Error instead of ConfigError, but wouldn't it be cleaner to put exception class inside Config? -- Config.Error? Would have to be on BaseSection. The more we add to BaseSection, the more we limit user in what sections they would be able to access via attribute access.