jbaublitz / neli

Rust type safe netlink library
BSD 3-Clause "New" or "Revised" License
180 stars 35 forks source link

`get_nested_attributes` doesn't need `&mut self` #220

Closed acheronfail closed 1 year ago

acheronfail commented 1 year ago

While using this I noticed that the .get_nested_attributes took mutable references, but I don't think the mut is required here.

This PR removes it (and targets the v0.7.0-rc2 branch).


By the way, v0.7.0-rc2 is looking really good IMO!

jbaublitz commented 1 year ago

@acheronfail Thanks for catching this! Could you also apply the change to rtnl.rs? The same problem exists there too.

acheronfail commented 1 year ago

@jbaublitz unless I've missed another one, this PR already contains an update to rtnl.rs which removes the mut?

jbaublitz commented 1 year ago

Whoops! I totally missed that. Merging now.