search

jbaublitz / neli

Rust type safe netlink library
BSD 3-Clause "New" or "Revised" License
180 stars 35 forks source link

Bug fix for race condition and unpredictable presence of DONE packet. #227

Closed jbaublitz closed 1 year ago

jbaublitz commented 1 year ago

Closes #223 Closes #214

cgzones commented 1 year ago

This indeed resolve #214; thanks!

Could you include a regression test to prevent future breakage?

jbaublitz commented 1 year ago

Absolutely. Is the specific operation you were running that triggered the bug sufficient to just add to a unit test or did you want something more involved?

cgzones commented 1 year ago

Is the specific operation you were running that triggered the bug sufficient to just add to a unit test or did you want something more involved?

Should be sufficient, since it was 100% reproducible for me.

jbaublitz commented 1 year ago

I'll try to get to this early next week.

dlon commented 1 year ago

Thank you for fixing this! @jbaublitz could you release a new version containing the fix?

jbaublitz commented 1 year ago

@dlon Working on #224 tonight and will hopefully release 0.7.0-rc3 by tomorrow.