Testflight deploy has a bug

[mrkite]

In the script, when checking the testflight settings at the bottom, you check for "apiKey" being set instead of "apiToken".

[jbavari]

Please check over the file thats being executed bin/cordova-deploy - is this the file you are talking about?

I think the index.js file isn't up to date, as I should remove that file.

See package.json points bin to be bin/cordova-deploy, not index.js

[mrkite]

Ah yes, it's correct there. I'm guessing the version being pulled by npm is old then.

[jbavari]

Oh ,crud, good point! I'll release it again.

Thanks for the heads up! I really appreciate it.

[sean-hill]

It seems that npm still has an old version. After running npm install -g cordova-deploy the code is as follows in the repo.

if(program.testflight) {
    console.log('testflight');

    if(typeof apiKey == 'undefined') {
        console.log('You did not supply a Test Flight API Token - you cannot proceed.'.red.bold);
        return;
    }

    if(typeof teamToken == 'undefined') {
        console.log('You did not supply a Test Flight Team Token - you cannot proceed.'.red.bold);
        return;
    }

    testFlightDeploys.deployIos(apiToken, teamToken, ipaPath, dsymPath, notes, distlist);

}

But the code on this repo is if(typeof apiToken == 'undefined') {

@jbavari when will npm be udpated? Thanks!

[jbavari]

Hey @sean-hill - Apple and TestFlight just announced they will be closing down TestFlight from their API. This tool will probably die with it, just as a heads up.

I'll keep you posted otherwise