jbbarth / redmine_base_deface

Integrate with the deface gem to manage view modifications in plugins
MIT License
40 stars 34 forks source link

RMPlus Custom_menu plugin conflict #4

Open dominch opened 9 years ago

dominch commented 9 years ago

hello, I decided to try rm plus custom menu plugin. There is some conflict and top of site is damaged, in error log there is:

^[[1;32mDeface: [ERROR]^[[0m The original source for 'add-maintenance-message-to-bodytop' has changed, this override should be reviewed to ensure it's still valid.
^[[1;32mDeface: [ERROR]^[[0m The original source for 'add-sudo-toggle-to-layout' has changed, this override should be reviewed to ensure it's still valid.

Error seems to come from base deface plugin (I'm using redmine_sudo too).

Both plugins works when only one is present.

nanego commented 9 years ago

Hi It may be a conflict between the _redminesudo plugin and the _rm_plus_custommenu plugin, as they both modify the header and they have never been tested together.

I don't think the issue really concerns this _redmine_basedeface plugin. These error messages only suggest that the overrides should be reviewed in the plugins where they are defined.

jbbarth commented 9 years ago

To make it clear, those errors in the logs just suggest a review but deface still tries to perform its overrides and everything may work in the end.

And agreed with @nanego for the rest :-)

Thanks for reporting!

Jean-Baptiste

Le 15 juil. 2015 à 11:40, vrobert notifications@github.com a écrit :

Hi It may be a conflict between the redmine_sudo plugin and the rm_plus_custom_menu plugin, as they both modify the header and they have never been tested together.

I don't think the issue really concerns this redmine_base_deface plugin. These error messages only suggest that the overrides should be reviewed in the plugins where they are defined.

— Reply to this email directly or view it on GitHub.

dominch commented 9 years ago

Thanks for fast replies :) Sure, I expected that deface + redmine_sudo performs very simple change in header, custom menu makes much more changes there. Both cause that top of page is corrupted and not usable any more. I like redmine_sudo plugin so for now I was forced to remove custom menu plugin. RMPlus don't have good place for issue reporting for now (as well as any git repo with this plugin).

rc5hack commented 8 years ago

Hello! I facing this issue:

The original source for 'add-maintenance-message-to-bodytop' has changed, this override should be reviewed to ensure it's still valid.

but there are no _redminesudo and no _rm_plus_custommenu plugins installed in my redmine 2.6.10. All my plugins are:

a_common_libs 2.1.8 redmine_base_deface 0.0.1 redmine_checklists 3.1.3 redmine_dashboard 2.7.1 redmine_maintenance_mode 2.0.1 rm_user_mentions 1.0.0