search

jbbarth / redmine_better_crossprojects

Temporary plugin to handle usability problems discussed on redmine.org #5920
http://www.redmine.org/issues/5920
12 stars 8 forks source link

Redmine error while opening projects page. #7

Closed druidPollux closed 10 years ago

druidPollux commented 10 years ago

The projects page cannot be opened anymore after upgrading the redmine_better_crossprojects plugin (my previous running commit was 4a24dbe8394a80f64a779a81547b3672cf2daaf7)

The log error in redmine is the following:

NoMethodError (undefined method `visible' for []:Array):
  app/models/query.rb:790:in `add_custom_fields_filters'
  app/models/query.rb:331:in `available_filters'
  app/models/query.rb:220:in `build_from_params'

My current redmine configuration: Environment: Redmine version 2.5.0.devel Ruby version 1.9.3-p484 (2013-11-22) [i386-mingw32] Rails version 3.2.17 Environment production Database adapter Mysql2 SCM: Subversion 1.8.4 Mercurial 2.7 Git 1.8.5.2 Filesystem
Redmine plugins: issue_hot_buttons 0.4.4 redmine_app__space 1.0.1 redmine_app_timesheets 1.3.5 redmine_base_select2 0.0.1 redmine_better_crossprojects 0.1 redmine_better_gantt_chart 0.9.0 redmine_category_tree 0.0.4 redmine_custom_workflows 0.0.4 redmine_information 1.0.3 redmine_issue_checklist 2.0.5 redmine_issue_status_colors 0.0.1 redmine_ldap_sync 2.0.3.devel.g7f1c325e31 redmine_login_audit 0.1.4 redmine_people 0.1.6 redmine_release_notes 1.3.1 redmine_watcher_groups 1.0.0 sidebar_hide 0.0.5

jbbarth commented 10 years ago

Thanks for the report, I'll have a look into it in the next few days. I may have merged @nanego's pull request a bit too soon but it was becoming pretty big and I wanted to tackle the problems independantly after the first big merge, the things he developed are awesome and I wanted them in this repo...

Anyway I'll keep you informed

jbbarth commented 10 years ago

I found the problem, it's related to the introduction of "visibility" on custom fields in Redmine 2.4.0. As I'm currently using 2.3.3 I didn't see the issue at first.

The fix is not trivial at first sight, so I advice you stay on 4a24dbe if it works for you. I'll work on that in the next few days/weeks as I plan to upgrade my instance on 2.4.3. I'll ping you back here when it's fixed.

druidPollux commented 10 years ago

OK, thanks. I'll stay on 4a24dbe for now,

nanego commented 10 years ago

I just fixed this issue. The last version of the plugin is now compatible with redmine 2.4 (it should also work on redmine 2.5 but I haven't tested it yet).

druidPollux commented 10 years ago

Fine. I'm still based on the redmine trunk,, so if you need me to do the test, just point me to the link to get this versoin.

nanego commented 10 years ago

You can get this fix with my last commit on the master branch: 22324e0d3f7748e3e3c18338bf5bbb99afa9b2b7

Please let me know if you get any error with this version.

druidPollux commented 10 years ago

Prefect, 22324e0 seems to run properly on redmine 2.5.0-devel Thanks.

nanego commented 10 years ago

Great! Thanks for the test.